Skip to content

Log Viewer: Improve layout on narrow viewports#23056

Draft
engijlr wants to merge 4 commits into
v17/devfrom
v17/improvement/log-viewer-mobile-responsive
Draft

Log Viewer: Improve layout on narrow viewports#23056
engijlr wants to merge 4 commits into
v17/devfrom
v17/improvement/log-viewer-mobile-responsive

Conversation

@engijlr
Copy link
Copy Markdown
Contributor

@engijlr engijlr commented Jun 3, 2026

Description

Improves the Log Viewer experience on narrow viewports (below 920 px). No changes affect the desktop layout.

Changes

  • Search view filter bar — on narrow viewports the level filter and date range no longer clip. The date range drops to its own full-width row below the level filter and polling button, using display: contents to avoid any template restructuring.
  • Message rows — each log entry reflows into a card layout: timestamp and level badge on the first line, full-width message below. The machine name column is hidden as it is not useful on mobile. The column header row is hidden to match.
  • Overview layout — the side-by-side stats panel and log tables stack vertically on narrow viewports.

This PR is build on top of: #23029 so it should be merge after

@claude
Copy link
Copy Markdown

claude Bot commented Jun 3, 2026

Claude finished @engijlr's task in 4m 23s —— View job


PR Review

Target: origin/v17/dev · Based on commit: cc5c743e

Adds responsive CSS and a burger-menu sidebar toggle to the backoffice so the Log Viewer (and section sidebar) is usable on viewports narrower than 920 px. No desktop layout is affected.

  • Modified public API: UmbSplitPanelElement — new sidebarOpen reflected boolean property/attribute; UmbBackofficeContext — new mobileSidebarOpen observable, toggleMobileSidebar(), setMobileSidebarOpen(); @umbraco-cms/backoffice/const — new export UMB_MOBILE_BREAKPOINT
  • Breaking changes: None — all changes are additive.

Suggestions

  • src/Umbraco.Web.UI.Client/src/packages/core/components/split-panel/split-panel.element.ts:53: sidebarOpen is the only @property() on this element without a JSDoc comment. The three existing properties (snap, lock, position) each have a /** ... */ doc block. Add one here to keep the public API surface documented.

  • src/Umbraco.Web.UI.Client/src/packages/core/components/split-panel/split-panel.element.ts:327-331 and 348-351: The slot[name='end'] flex rule (flex: 1 1 auto; min-width: 0) appears twice — once at root level and again inside the @media block. The root rule already applies on mobile, so the media-query repetition is redundant.

    /* root — already covers mobile */
    slot[name='end'] {
        flex: 1 1 auto;
        min-width: 0;
    }
    
    /* inside @media — the :host([connected]) wrapping doesn't change the flex behaviour */
    :host([connected]) slot[name='end'] {
        flex: 1 1 auto;   /* ← same values, can be removed */
        min-width: 0;
    }
  • src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/views/overview/log-overview-view.element.ts:179: Inside the mobile @media block, #common-messages-container is given grid-area: common-messages again — but the parent switched to display: flex, so grid-area has no effect. Only the --uui-box-default-padding override matters here; the grid-area line can be dropped.

  • src/Umbraco.Web.UI.Client/src/packages/core/section/default/default-section.element.ts (mobile UX): The sidebar overlay currently closes on navigation (changestate) and on viewport resize back to desktop. There is no click-outside or swipe-away handler. For a first iteration this is reasonable, but tapping the page content while the sidebar is open leaves it open with no escape other than the burger button. Worth a follow-up.


Approved with Suggestions for improvement

The implementation is solid: clean CSS-only responsive breakpoints for the log viewer, a well-structured context-driven sidebar toggle, and proper cleanup in connectedCallback/disconnectedCallback. The suggestions above are minor polish items — none need to block merge.

@engijlr engijlr marked this pull request as draft June 3, 2026 13:24
@claude claude Bot added area/frontend category/ux User experience category/ui User interface labels Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend category/ui User interface category/ux User experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant